`kraken`: order mode modifcation of orders doesn't cancel/edit the order and instead just leaves them stale!

pikers / piker

(e2e) foss trading for non-tinas

GNU Affero General Public License v3.0

103 stars 17 forks source link

`kraken`: order mode modifcation of orders doesn't cancel/edit the order and instead just leaves them stale! #299

Closed goodboy closed 2 years ago

goodboy commented 2 years ago

Massive bug that i'm not sure how we missed...

Currently there's no use of the editOrder endpoint and further no cancelling of submitted live orders such that if a user modified a live submission the original order is left stale without any indication of this to the user and further a new order is submitted at the new target price..

This is a massive issue and needs to be addressed asap!

I will be disabling kraken order mode support in #298 until this is resolved.

iamzoltan commented 2 years ago

addressed in a new PR #300

iamzoltan commented 2 years ago

PR #300 merged