search

pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
103 stars 17 forks source link

Can we drop `pandas`? #316

Closed goodboy closed 2 years ago

goodboy commented 2 years ago

https://github.com/pikers/piker/pull/308#discussion_r867542248 says we can right?

last usage is see is for an old piker.data.marketstore.timestamp() epoch formatter? Pretty sure we can just use pendulum no?

I definitely see no reason to keep it as a hard dep right now..

goodboy commented 2 years ago

Ahh we can't yet drop it fully because anyio-marketstore needs it for Timestamp stuff currently. I'm sure we can pull that out if wanted though?

We need to make sure we can track nanoseconds in the parser that replaces it and pretty sure that pendulum supports that with .timestamp() / .float_timestamp().

goodboy commented 2 years ago

First bit getting us there is https://github.com/pikers/anyio-marketstore/pull/4 🏄🏼

goodboy commented 2 years ago

Resolved via #320