search

pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
102 stars 17 forks source link

Brokercheck an all backends #393

Closed guilledk closed 1 year ago

guilledk commented 1 year ago

Begin work on #387

Do a brokercheck without logging on all backends, we pull backends from piker.brokers.__brokers__, I added deribit while I was at it cause I forgot to when doing the backend PR.

Currently not passing cause binance doesn't have a trades_dialogue, or get_balance.

Also should we log to console more like when running brokercheck on cli? This would require log_cli flag to be set on pytest config.

goodboy commented 1 year ago

Currently not passing cause binance doesn't have a trades_dialogue, or get_balance.

Can we just maybe have a parameterization based on some kind of "supported" features log? I'm thinking we could check the backend subpackage module for an table that maybe denotes which features are supported and then we map those flags to a method set?

Also should we log to console more like when running brokercheck on cli? This would require log_cli flag to be set on pytest config.

Don't see why not, you can set it in the test module or a pytest.ini iirc.

goodboy commented 1 year ago

Replaced by warnings added in #489