pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
102 stars 17 forks source link

Kraken fill bugs #399

Closed goodboy closed 1 year ago

goodboy commented 1 year ago

Even more..

Turns out that refactoring from relaying BrokerdFill from the openOrder sub wasn't tested all too well 😂.

Fixes a 2nd name error for the .broker_time field (which isn't provided in the incremental update msg so this just sets it as the brokerd time (from time.time()) for now; comments added about how we might approach getting the ownTrades (the original value we were passing) in the response message eventually.

Also included is a further fix to the paper engine to just avoid trying to pop simulated order book entries on modifies since it's not really necessary and further it was the source of a linger race-crash with the actual paper clear case (popped after already popped by clear task).