search

pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
103 stars 17 forks source link

Pps toml header leaking after zeroing positions #472

Closed jaredgoldman closed 1 year ago

jaredgoldman commented 1 year ago

When a user enters a position, stops the service tree and then boots it back up and zeroes the pp, the header for the position i.e [binance.paper] is leaked. It might have to do with the way we're loading the pps when booting up the paper actor to update UI slotting but by default we shouldn't be writing on that call. The expected behavior is that once a position is cleared, no record will appear in a user's pps.toml.

For context, these issues were reported in https://github.com/pikers/piker/pull/462

goodboy commented 1 year ago

Pretty sure this was mostly resolved prior to #489 but either way it's solved by that for sure since we're no longer doing mult-broker pps files and instead each broker account has it's own account...toml file now B)