order mode pane UI bugs.. - Githubissues

pikers / piker

(e2e) foss trading for non-tinas

GNU Affero General Public License v3.0

102 stars 17 forks source link

order mode pane UI bugs.. #479

Open goodboy opened 1 year ago

goodboy commented 1 year ago

There have been lingering for some time and need to be resolved stat!

This likely has much to do with the previously documented problems in https://github.com/pikers/piker/issues/220 as well.

Bugs!

[ ] on a units limit (for eg. for mnq futes): have an existing pp with all slots filled then increase the limit (eg. 6 -> 8) and then switching back to making the slots match the limit size, the limit will revert to it's previous value of 6..

https://user-images.githubusercontent.com/291685/222814450-c99198a2-47c0-4097-9d8c-5e2d46ead188.mp4

ideally the UX is,

on any change to a units limit, for any discrete sized asset (legacy mkt equities, futes, opts..) that is greater then the # of slots, we should automatically change the slots to match the limit => since you can't have a slot that is any less then 1 unit.

[ ] for $fiat limit: 6k limit, enter < 6 slots, switch the slots count to 1 -> causes an empty / unfilled health bar to show instead of the fractional fill as prior.

https://user-images.githubusercontent.com/291685/222814459-f4d5497f-cd5a-4979-8956-baa5982cd643.mp4