pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
102 stars 17 forks source link

Better `TOML` libs -> `tomlkit` for style, `tomli(-w)` for speed #496

Open goodboy opened 1 year ago

goodboy commented 1 year ago

Since we already had to roll our own based on writing a particular styled .clears table to the pps.toml file, this is a task to choose the best (combo of) lib(s).

Here's the verbatim bullet-task breakout from #345:


Turns out there's been a bunch of project updates in the space 🙏🏼,

goodboy commented 1 year ago

personal todo: Need to link our PR for inline array comment config support and possibly open an issue to support passing through such inputs to .item.array()

goodboy commented 1 year ago

Linking in tomlkit issues we need in order for us to be able to use that lib:

goodboy commented 1 year ago

Heh, i actually was on the side of this issue / request submitted to the spec: https://github.com/toml-lang/toml/issues/516

After reading it though, i don't think multi-line tables really are that necessary.

Interested in what others think though as well.