pikers / piker

(e2e) foss trading for non-tinas
GNU Affero General Public License v3.0
103 stars 17 forks source link

`binance`: live order followup/refinements #524

Open goodboy opened 1 year ago

goodboy commented 1 year ago

After #520 lands we still have some lingering questions and todos to get full .accounting position tracking support.

Pulling in remaining bullets from that PR content:


Order control questions:


Position tracking via .accounting sub-sys:

Currently we are completely deferring to binance's own internal position / balance reporting and we haven't added any support for transaction ledgers.


Running futes and spot venue brokerd tasks in parallel?

Currently we have no way to indicate to the particular brokerd instance whether the futes or spot venue should be attached for the user stream wss. Ideally we actually connect to both (so that inbound EMS requests are routed appropriately based on msg content) but that requires concurrency (in terms of the current task tree design from open_trade_dialog() downward) and is a design we should discuss both in terms of performance and configuration details.