search

pikim / grav-plugin-events

This plugin provides Calendar Events for Grav CMS
MIT License
13 stars 11 forks source link

Fixed admin save event / geocoding in admin #37

Closed LiaraAlis closed 1 month ago

LiaraAlis commented 9 months ago

When using Grav v1.7.43 with Admin v1.10.43, the onAdminSave admin has no effect. Address is not geocoded even it's enabled in plugin configuration.

This is caused by 2 problems:

  1. Object is an instance of PageObject instead of Page: https://github.com/pikim/grav-plugin-events/blob/12b599c8f162c2a739630f8a6366fb36b4efc3d7/events.php#L315 https://github.com/pikim/grav-plugin-events/blob/12b599c8f162c2a739630f8a6366fb36b4efc3d7/events.php#L363

  2. Indirect modification of overloaded property is not possible: https://github.com/pikim/grav-plugin-events/blob/12b599c8f162c2a739630f8a6366fb36b4efc3d7/events.php#L340

This commit fixed both.