search

pikim / grav-plugin-events

This plugin provides Calendar Events for Grav CMS
MIT License
13 stars 11 forks source link

quark "hard coded" template dependencies #7

Closed sherpadawan closed 4 years ago

sherpadawan commented 4 years ago

Hi ! If you take a look to the template on which the plugins depends. You'll see ther are missing in the plugin templates directory. A plugin should not depend on a specific theme and should be able to work on any theme. partials/base.html.twig and other dependencies must exists in the templates folder. Is it clear enough for you ? Thanks in advance Guillaume

sherpadawan commented 4 years ago

If you take a look to this file you'll see base is not provided, others are deactivable from page headers , default values should not be TRUE by the way, unless the plugin provide default templates (i am not shure it is its responsability) https://github.com/pikim/grav-plugin-events/blob/master/templates/events.html.twig

sherpadawan commented 4 years ago

Ok sorry for the mess... I just read that the partials/base.html.twig is a 'requirement' for a theme. I don't understand why chunk templates dans main default template are in the same folder. That's a weird idea. Anyway it is the default behaviour. I close the ticket !