pilagod / gorm-cursor-paginator

A paginator doing cursor-based pagination based on GORM
https://github.com/pilagod/gorm-cursor-paginator
MIT License
192 stars 44 forks source link

fix (paginator): fix panic when isNil(...) is called with an arrary #48

Closed jimlambrt closed 2 years ago

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 217


Totals Coverage Status
Change from base Build 216: 0.5%
Covered Lines: 364
Relevant Lines: 372

💛 - Coveralls
coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 218


Totals Coverage Status
Change from base Build 216: 0.5%
Covered Lines: 364
Relevant Lines: 372

💛 - Coveralls
jimlambrt commented 2 years ago

@pilagod - we bumped into this issue because we're using google's uuid in our models and it's defined as type UUID [16]byte

pilagod commented 2 years ago

Thanks for the finding. I think this is a quite common case this library should take care of.

LGTM. I am going to merge it 💪

pilagod commented 2 years ago

I have published v2.3.1 and can upgrade to it for this fix 💪