Closed jpugliesi closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
paginator/paginator.go | 3 | 5 | 60.0% | ||
<!-- | Total: | 3 | 5 | 60.0% | --> |
Totals | |
---|---|
Change from base Build 4999052293: | -0.5% |
Covered Lines: | 355 |
Relevant Lines: | 370 |
@jpugliesi @nikicc That's awesome! Looks perfect to me. If there is no further discussion, I will merge it and release a new version to include this fix.
Great, thank you @pilagod
@pilagod you're a rockstar 🤟 Thanks so much 🙏
Some SQL dialects (like Clickhouse) do not automatically cast strings
'%v'
to the appropriate column type, resulting in an error when this is attempted. This causes an error when using apaginator.Rule
on a non-string type column.To circumvent this issue, the fix here explicitly casts the
NULLReplacement
value to the providedSQLType