coveralls
commented
9 months ago Pull Request Test Coverage Report for Build 7958280161
Details
- 0 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.6%) to 96.533%
| Totals | |
|---|---|
| Change from base Build 5418911557: | 0.6% |
| Covered Lines: | 362 |
| Relevant Lines: | 375 |
pilagod
zitnik
nikicc
This PR aims to add support for NULL value replacement in custom types. Builds upon #39 and #44.
Current issue
The issue that I came across with the current implementation is that when the pagination cursor includes
nullfor a custom type, that value is not properly replaced with theNullReplacementvalue. The reason is that the Go-representation of the cursor value is not nil, but a custom type object (with an underlying value of nil).This in turn causes the pagination WHERE clause to compare the COALESCEd values of the target column with an unreplaced NULL, e.g.
WHERE COALESCE(my_attr, '') > NULL.Implementation
The change in this PR specifically handles custom types in the
isNilfunction so that for custom types we evaluateisNilon the underlying value retrieved byGetCustomTypeValueinstead of on the object itself.Test
In order to construct a test, I added a custom type as an alias of
sql.NullString, implemented the necessary methods on this type, and added a new field to theorderstruct. I guess this is a bit clumsy, in case you have any ideas about how to construct such a test more compactly, please let me know :) In the test itself, we have a primary pagination rule on "Remark" and a secondary rule on the new "Description" field so that the NULL element (ID 2) appears in the cursor causing the described problem.