search

pilcrowonpaper / lucia-adapter-astrodb

Astro DB adapter for Lucia.
MIT License
106 stars 6 forks source link

Astro DB no longer exports type Sqlitedb #15

Closed OliverSpeir closed 3 months ago

OliverSpeir commented 5 months ago

Doesn’t break anything but figured it was worth noting

https://github.com/pilcrowOnPaper/lucia-adapter-astrodb/blob/ecefa40be925b877e4bdf22b833fae1ce601f2f2/src/index.ts#L4

Think this was changed in https://github.com/withastro/astro/pull/10457

Thanks so much for making this by the way, if you have an idea for how you want to do the type I could make a PR

pilcrowonpaper commented 5 months ago

I can't seem to find a type to replace it with so this might need an action from Astro's side. Trying to confirm this with the maintainers right now

OliverSpeir commented 5 months ago

Ok so https://github.com/withastro/astro/pull/11216 starts exporting the type again which should go out with @astrojs/db@0.11.5

Now the consideration is that the type has been (accurately) renamed to Database instead of SqliteDB

pilcrowonpaper commented 5 months ago

Thanks for making the PR!

millette commented 4 months ago

@pilcrowOnPaper I didn't see a PR here for this issue so I made #16.

I was a little bit confused since the git tag says 0.0.8 but the npm published version is 0.0.9.