search

pilebones / go-udev

Simple udev implementation in Golang
GNU General Public License v3.0
95 stars 28 forks source link

udev: skip TestParseUdevEvent on s390x #13

Closed mvo5 closed 6 years ago

mvo5 commented 6 years ago

The input byte data is hard-coded for little-endian architectures.

However the s390x is big endian so this test always fails because the data is incorrectly aligned. The easiest solution for now is probably to just skip the test. The best solution of course is to update the input data for big-endian :)

pilebones commented 6 years ago

Indeed I have hardcoded the udev stream for little-endian architecture, up to now nobody used this project on big-endian architecture so thank you for this PR.

Temporary I will merge your fix (without closing the PR) but implement a better solution by testing endianess of the target architecture. Can you validate this future development on the s390x please ?

Best.

mvo5 commented 6 years ago

Thanks a lot @pilebones - happy to test this on s390x and I agree, I think a proper endian test is the way to go :)