search

pilhuhn / hawkfx

Hawkular explorer written in (J)Ruby with a JavaFX frontend.
Apache License 2.0
14 stars 10 forks source link

Add basic ability to create Compare condition trigger #31

Closed jshaughn closed 7 years ago

jshaughn commented 7 years ago

@pilhuhn Please take a look and see if this is OK to add to hawkFx.

pilhuhn commented 7 years ago

While I think that the selection of different possible conditions should not done via menu item, but later in that popup, I think that is good to go in. Would have been good to add a basic spec for the new comparator. Thanks a lot @jshaughn

jshaughn commented 7 years ago

@pilhuhn You're right on all counts. I didn't love having this on the main menu. But I wasn't sure of a nicer way to go at this point, and didn't want to invent one, so I stuck to the existing infrastructure. In truth the compare condition should have a way to select the second metric but what I did was just make a "best guess" at what it may be named. As for the spec, I'll try and add something next time I'm in this stuff.

By the way, is the List Alert Triggers thing supposed to work? It didn't work for me but I didn't look into it.