pass the Configuration to the JavaScriptRenderHandler as well

pilif / sacy

Smarty Asset Compiler (warning: all branches but master are subject to force pushes)

http://pilif.github.com/sacy

MIT License

34 stars 12 forks source link

pass the Configuration to the JavaScriptRenderHandler as well #30

Closed mkuettel closed 5 years ago

mkuettel commented 5 years ago

This caused an error when using an {asset_compile}.

Argument 1 passed to sacy\internal\ConfiguredRenderHandler::__construct() must implement interface sacy\Configuration, instance of sacy\internal\BlockParams given, called in .../sacy/internal/CacheRenderer.php on line 76

For details see: https://sensational.zendesk.com/agent/tickets/12679

mkuettel commented 5 years ago

@pilif I cannot add you as a reviewer here, that's why I'm pingng

pilif commented 5 years ago

ha! Thank you - I totally missed that in the refactoring. Good thing we have tests :p