search

pilifs / gortpong

Table tennis ladder for team Gort @ Bitmaker
4 stars 3 forks source link

Gort center #2

Closed blissman closed 8 years ago

blissman commented 8 years ago

Hey team,

Have a look! I'd like to add video embedding to GortCenter.

pilifs commented 8 years ago

This is really cool, great job Bliss! Love it all. I am thinking we should add a widget to the front page specifically for GortCenter. Probably in the top right of the index view where the game log currently sits, pushing the log further down the page. Not 100% exactly what the best content to fit in there would be but it could be as simple as showing the latest video or featured videos of matches. Regardless, it would make the home page more exciting.

pilifs commented 8 years ago

Couple things:

  1. I think we should make it more prominent to show that a link to the game show page means there is a video. There is value in linking to all game show pages even if there are no videos (for future design consideration, and we can display things like winning percentage in there). I would like to see a play button somewhere on the game log table to indicate this. We can/should make the table in our root view a row wider to accommodation it.
  2. We need to indicate to the user somehow that fields are optional, so they don't think they have to add a video in order to submit a game! I propose we make an optional fields section in the game submit form. This will make it really easy to extend for future design considerations as well. One thing we've talked about a lot is allowing users to add comments when they submit a game.

Let me know how you feel about doing this stuff, Bliss. If you don't have time I'd be happy to do one or both. Otherwise, looks good and great job again!

cstaikos commented 8 years ago

This all sounds good to me! I would maybe suggest instead of a whole section of optional fields we could perhaps just add a red star next to the labels of the required fields, with a legend indicating that that means it's a required field. This is super easy to do w/ CSS:

.required::after { content: "*"; color: red; }

..then we just add that class to any labels of required fields, and it will insert the * after it via CSS.

Agreed that it'd be awesome to include an icon on the game log indicating when there's a video to display - would show people that it exists and encourage them to include them!

Thanks Bliss for putting this together :)

On Mon, Feb 8, 2016 at 10:28 PM, Filip Stankovic notifications@github.com wrote:

Couple things:

1.

I think we should make it more prominent to show that a link to the game show page means there is a video. There is value in linking to all game show pages even if there are no videos (for future design consideration, and we can display things like winning percentage in there). I would like to see a play button somewhere on the game log table to indicate this. We can/should make the table in our root view a row wider to accommodation it. 2.

We need to indicate to the user somehow that fields are optional, so they don't think they have to add a video in order to submit a game! I propose we make an optional fields section in the game submit form. This will make it really easy to extend for future design considerations as well. One thing we've talked about a lot is allowing users to add comments when they submit a game.

Let me know how you feel about doing this stuff, Bliss. If you don't have time I'd be happy to do one or both. Otherwise, looks good and great job again!

— Reply to this email directly or view it on GitHub https://github.com/pilifs/gortpong/pull/2#issuecomment-181690075.