search

pillar-markup / pillar

Markup syntax and associated tools to write and generate documentation, books and slides
MIT License
51 stars 37 forks source link

visitListItem: default looks wrong #279

Open Ducasse opened 6 years ago

Ducasse commented 6 years ago

PRVisitor>>visitListItem: anObject self visitDocumentGroup: anObject

It is plain bogus because document group expect that the object has children!

So it means that a list item such a bib entry cannot default its visitBibEntry: visitor to visitListItem: but at the same time visitDocumentItem: is not implement on HTML writers so the defaulting behavior cannot be expressed!.

Ducasse commented 6 years ago

Now it looks like all the visitListItems: implementation invoke PRVisitor>>visitListItems: which is

visitListItem: anObject self visitDocumentGroup: anObject

visitDocumentGroup: anObject self visitAll: anObject children

Ducasse commented 6 years ago

Now I checked all the subclass of documentGroup and I do not understand why PRFormat is a group?