pillargg / pillar_algos

Finds best timestamps to cut at
https://docs.pillar.gg/pillar_algos/
GNU General Public License v3.0
1 stars 0 forks source link

Combine multiple algorithms? #23

Closed RusseII closed 3 years ago

RusseII commented 3 years ago

When viewing the clips I noticed that the best clips were often picked up by several of the algorithms. Would it make sense to look across all the algorithms and see which clips were identified by multiple of the algorithms and assume those clips are better? Or does that not make sense?

pomkos commented 3 years ago

Yes, please see the readme for more details.

pomkos commented 3 years ago

Oh you mean look at timestamps. Sure, should be easy enough to implement.

pomkos commented 3 years ago

Done, with unit test yay. Script here.

pip install pillaralgos==1.0.11

from pillaralgos import brain
json = brain.run(data, x=1, limit=None)
pomkos commented 3 years ago

Let me know how it works

chand1012 commented 3 years ago

Has this been completed? Seems like #30 would close this.

pomkos commented 3 years ago

I'm gonna close it. @RusseII reopen if you find issues.