pillargg / pillar_algos

Finds best timestamps to cut at
https://docs.pillar.gg/pillar_algos/
GNU General Public License v3.0
1 stars 0 forks source link

Brain v1.0.12 does not work #37

Closed RusseII closed 3 years ago

RusseII commented 3 years ago

brain_results = brain.run(all_messages, clip_length=.75, limit=10)

{"errorMessage": "'chats_per_0.5min'", "errorType": "KeyError", "stackTrace": [" File \"/var/task/handler.py\", line 33, in handler\n algo2_result = algo2.run(allmessages, min=.5, limit=10)\n", " File \"/var/task/pillaralgos/algo2.py\", line 144, in run\n json_results = d.results_jsonified(results, first_stamp, f\"chatsper{min_}min\")\n", " File \"/var/task/pillaralgos/helpers/data_handler.py\", line 304, in results_jsonified\n results = results.sort_values(\n", " File \"/var/task/pandas/core/frame.py\", line 5455, in sort_values\n k = self._get_label_or_level_values(by, axis=axis)\n", " File \"/var/task/pandas/core/generic.py\", line 1684, in _get_label_or_level_values\n raise KeyError(key)\n"]}%

Input data - https://slstack-messagestore60e7afc8-fcvaaengplyv.s3.amazonaws.com/963184458

pomkos commented 3 years ago

Its going to take me a while to resolve issues at this time, if someone else could take this one I'd appreciate it.

pomkos commented 3 years ago

I could not replicate the bug using 1.0.12 from pypi.

pip install pillaralgos==1.0.12

image
pomkos commented 3 years ago

Confirmed works for clip_length = 0.75 as well. @RusseII

image
RusseII commented 3 years ago

Confirmed works for clip_length = 0.75 as well. @RusseII

image

Why are all of these clip times 110+ seconds? They should be .75 * 60 = 45 seconds.

example from first clip in your image: 12926 - 12849 = 77 seconds example from 2nd clip: 3285 - 3405 = 120

pomkos commented 3 years ago

weird

pomkos commented 3 years ago

pip install pillaralgos==1.0.13

Let me know if it worked.

pomkos commented 3 years ago

Also updated test_brain.py to test for both answer and the answer length.