Open zachasme opened 5 years ago
Is input a string if wrapped in String constructor? I suggest no, as do Node. That is also what I went with in the PR.
Yea, I have just done the same type of validations that Node.js APIs use, which is just typeof
, only considering primitive types and not the boxed types.
When is input omitted? Logically undefined. But there are tests for expiring cookies using null. What about false? I feel undefined and null should cover it
From a JavaScript POV, it is just undefined
. The two tests passing in null
, are testing that any falsy value works, so that would mean the API contract there does indeed false
and 0
.
Would you prefer only considering input as omitted on undefined
then? If so I can quickly update the PR accordingly.
Resolves #101.
This enforces string input as suggested by @dougwilson.
Two considerations:
String
constructor? I suggest no, as do Node. That is also what I went with in the PR.undefined
. But there are tests for expiring cookies usingnull
. What aboutfalse
? I feelundefined
andnull
should cover it (an explicitCookies.remove
would avoid ambiguity, see #98).