Closed wesleytodd closed 2 months ago
I am about to rebase this onto the new CI and lint changes. I should probably just life out the changes, but I like a challenge with git and what is the point of doing this if we are not having fun while we do it?
ok I think I did this correctly. There was a duplicate test and a few things which made it confusing, but I think once we get path-to-regexp@8
released this is nearly ready.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/path-to-regexp@8.0.0 | None | 0 |
51.3 kB | blakeembrey |
🚮 Removed packages: npm/path-to-regexp@3.2.0)
Updates to
path-to-regexp@8
.So from the tests, the three breaking changes are:
router.route('/user(s?)/:user/:op')
but still have optional non-capture/user{s}/:user/:op
:name?
becomes{:name}
:name*
becomes*name
.{*name}
:name+
becomes*name
and thus equivalent to*name
so I dropped those testsI am going to link this into
express
and see locally if this set of breaking changes holds up in that test suite now.