search

pillarjs / router

Simple middleware-style router
MIT License
409 stars 102 forks source link

Promise support for `router.param` #91

Closed jonchurch closed 7 months ago

jonchurch commented 4 years ago

This is a reminder to myself (or anyone else) to implement this and give a smooth upgrade path to users of express-async-errors

https://github.com/davidbanham/express-async-errors/issues/28

jonchurch commented 4 years ago

@dougwilson Can you assign this issue to me? I don't seem to have perms to do that in this repo.

wesleytodd commented 7 months ago

@jonchurch are you still interested in working on this? If you are, I would love to figure out how we can land holistic promise support before router@2 happens. I have this one in flight from a while back as well: https://github.com/pillarjs/router/pull/75

jonchurch commented 7 months ago

Yeah Im interested. Need to dig up old stuff from the past but I had reached out to the maintainer of a popular package that monkey patched router with promise support.

If I can coordinate a release there to not crash when people use it with a native promise supporting router that would be great

jonchurch commented 7 months ago

@wesleytodd oh this merged but the issue wasn't closed https://github.com/pillarjs/router/pull/92