code review

[thezoggy]

looking through the code I see numerous coding mistakes / spelling mistakes / cosmetic issues.. is this project dead or am i wasting my time on even worrying about it?

https://github.com/pillone/usntssearch/blob/0.48/NZBmegasearch/SearchModules/ac_NZBcc.py#L59

[G1zm0]

I hope the project is not dead, It is a nice project, but I see less respons from the developer.

[thomaswasilewski]

I think, sadly, its dead.

But maybe somebody (or you thezoggy) could branch it and continue developement (Sadly I don't know s*\ about python, so I'm out). There are still things to resolve like you pointed out and issues like the need for parsing a category when sending to nzbget or sab (wink).

pls somebody branch and continue this!

[thezoggy]

I did fork this and Started to look through the code... There is plenty of stuff that needs some TLC. Fork I used has plenty of 'fixes' not in the official version...

-----Original Message----- From: "bamdaschmu" notifications@github.com Sent: ‎4/‎16/‎2015 8:41 AM To: "pillone/usntssearch" usntssearch@noreply.github.com Cc: "thezoggy" thezoggy@gmail.com Subject: Re: [usntssearch] code review (#149)

I think, sadly, its dead.

But maybe somebody (or you thezoggy) could branch it and continue developement (Sadly I don't know s*\ about python, so I'm out). There are still things to resolve like you pointed out and issues like the need for parsing a category when sending to nzbget or sab (wink).

pls somebody branch and continue this!

---

Reply to this email directly or view it on GitHub: https://github.com/pillone/usntssearch/issues/149#issuecomment-93736816

[Mirabis]

I planned to continue this, but time is a limiting factor as I prefer to rewrite it entirely.

Alternatively, I would write it in C#/mono >.<

[tifoji]

For anyone following this, to update to v51 using Mirabis/thezoggy's forks

[flask-blahblah.rhcloud.com usntssearch]> pwd /var/lib/openshift/xxxxxxxxxxxxxxxxxx000001/app-root/repo/wsgi/usntssearch

[flask-blahblah.rhcloud.com usntssearch]> git remote -v origin https://github.com/pillone/usntssearch.git (fetch) origin https://github.com/pillone/usntssearch.git (push)

[flask-blahblah.rhcloud.com usntssearch]> git remote set-url origin https://github.com/thezoggy/usntssearch.git

[flask-blahblah.rhcloud.com usntssearch]> git remote -v origin https://github.com/thezoggy/usntssearch.git (fetch) origin https://github.com/thezoggy/usntssearch.git (push)

[flask-blahblah.rhcloud.com usntssearch]> cd NZBmegasearch/openshift/

[flask-blahblah.rhcloud.com usntssearch]> ./install_openshift.sh

[flask-blahblah.rhcloud.com usntssearch]> ctl_app retstart

That should do the trick.

[tifoji]

Does NZBGet integration work for anyone? I do not see Send to NZBGet icon in the search results. I have tried it in Chromium as well as Firefox. NZBGet integration works fine for me in some of the well known underground indexes directly but I'd rather have it in NZBMegaSearch

[Mirabis]

It's not working for me either, even the API of nzbmegasearch is flaky for me

[thezoggy]

@siuside my repo had only local mods, pushed some out.. first thing was just cleaning up some code / validate pulls to make sure stuff was still working..

[tifoji]

No worries. Your repo is forked from Mirabis/usntssearch, so it captures all his updates and yours. I noticed Mirabis mentioning earlier in this Issue that he hasn't got the time, so I cloned yours. We really need more devs taking this fantastic project over.

[Mirabis]

Due to some recent changes in my projects, i'm looking into fixing stuff around the project. At first wanted to remake it ... but after 2 hours i was like... it's not that bad, can just continue xD

[Mirabis]

Fixed most stuff @https://github.com/Mirabis/usntssearch/commit/44e843619a40c83c295a16ad384a9c6ab352e76e

[tifoji]

@Mirabis

That is a massive update ! Thanks.. Hopefully you are posting in r/usenet to spread the word :)

[Mirabis]

@siuside hehe first wanted to recreate it in my own way - but ended up just editing it and hoping one day he might pick it up again :)

Havn't made a reddit post.... maybe next week

[G1zm0]

I made a package for Synology users using Synnocommunity. The package requires Python from Synnocommunity (of course) .

The package can be found in this link

Disclaimer: This is my first try making a package. I just changed the link tot the git repo. It worked on a test-synology I use with DSM5.2

[Mirabis]

mmm still hit or miss with the warp ... 404 .. gotta look into that - any of u experienced it as well?

[tifoji]

Not seeing any 404s whatsoever when I search. Maybe I can try to duplicate if you share with us exactly what you do to trigger the error.

[Mirabis]

@siuside 404 seems to be resolved when not using a reverse proxy ;S Behind a reverse proxy it feeds nzbdrone/couchpotato the urls but the urls are wrong ; (

[punkhop]

So which repo should I install from, @Mirabis or @thezoggy ? I just created a new OpenShift gear and (successfully, I think) installed from thezoggy, but I get a 404 error after the install.

[thezoggy]

Use mirabis

-----Original Message----- From: "punkhop" notifications@github.com Sent: ‎6/‎8/‎2015 8:01 PM To: "pillone/usntssearch" usntssearch@noreply.github.com Cc: "thezoggy" thezoggy@gmail.com Subject: Re: [usntssearch] code review (#149)

So which repo should I install from, @Mirabis or @thezoggy ? I just created a new OpenShift gear and (successfully, I think) installed from thezoggy, but I get a 404 error after the install.

---

Reply to this email directly or view it on GitHub: https://github.com/pillone/usntssearch/issues/149#issuecomment-110186659

[tifoji]

@punkhop

You do not need new gear. I got a notification from your original query but looks like you might have deleted it, but I thought I'd post here for everyone's benefit. To update to Mirabis fork, run the following commands and you should be able to update to v53.

The pwd is here just for demo to show which subdirectory one needs to be in order to run the commands (all the way upto /var/lib/openshift/xxxxxxxxxxxxxxxxxx000001/app-root/repo/wsgi/usntssearch)

[flask-blahblah.rhcloud.com usntssearch]> pwd /var/lib/openshift/xxxxxxxxxxxxxxxxxx000001/app-root/repo/wsgi/usntssearch

[flask-blahblah.rhcloud.com usntssearch]> git remote -v origin https://github.com/pillone/usntssearch.git (fetch) origin https://github.com/pillone/usntssearch.git (push)

[flask-blahblah.rhcloud.com usntssearch]> git remote set-url origin https://github.com/Mirabis/usntssearch.git

[flask-blahblah.rhcloud.com usntssearch]> git remote -v origin https://github.com/Mirabis/usntssearch.git (fetch) origin https://github.com/Mirabis/usntssearch.git (push)

[flask-blahblah.rhcloud.com usntssearch]> cd NZBmegasearch/openshift/

[flask-blahblah.rhcloud.com usntssearch]> ./install_openshift.sh

[flask-blahblah.rhcloud.com usntssearch]> ctl_app retstart

[punkhop]

Switched to @Mirabis's repo and got it up and running - but my log is full of errors:

http://mega-peet.rhcloud.com/log

[Mirabis]

Looks like u toggled 'Https' and ur config file is missing the 'general' section ;o Does ur install have a custom_params.ini file?

[punkhop]

Uhhhh, it shouldn't. I didn't mess with anything after the install.

[Mirabis]

Hmm - does it work though? If -so u can ignore the errors for now. Will check if I get the same later.

Ur reverse proxy is set to : http://gyazo.com/64388a3737301f71d71d2b3b03effc85 -> remove that ( did it for u xD)

PS: Your site does not ask for username/password, I could access ur /config freely :-1:

[punkhop]

Yeah, I did that on purpose for now so you could check it out hassle-free. I'll see if it works. I was running all my usenet apps on my hackintosh but moved them to my Synology and I can't get them working right with permissions. Once I get em right then I can test. If I ever do.