Design Changes and Security Fix

[PeterBeard]

I made a few changes that I thought might be of some use:

• Refactored HTML and CSS to be more standards-compliant
• Redesigned search and config pages to be more consistent with the logo and each other
• Added support for message flashing
• Fixed #14 by salting and hashing HTTP auth passwords
  • This is backwards compatible so that users with plaintext passwords can still login, but the user will be warned that they should update their password for better security

Pictures of the new design:

[JackDandy]

Personally, i dont like boxes inside boxes - it's overkill. I would remove the outer green and grey border. Keep lines to a minimum. If anything needs a change there it would the logo.

Where are the trends etc. they are super useful.

Why move the position of the error message? Keep it where it is, the eyes are trained to being looking at there on the page for results. Indeed, there is no need to look up unless going to config or log which is all ready well designed. This new design means that when I look at the results area, I then also have to look up if there are no results. Apart from the positioning, the red highlight is good.

Final comment, if this design hides stuff in a way that cant be unhidden on a permanent basis as is right now, then it isn't good for people who are confortable with things the author already created.

[PeterBeard]

I'll get rid of the green box and upload some images and see what people think of it either way. I kind of like the logo; the changes I made were supposed to sort of fit in the same theme.

I had the trends disabled when I was making screenshots, but they show up when they're turned on. I'll post some pictures of them when I get a chance.

I thought it made sense to have the message appear at the top of the page, but I can see it being more obvious in the results area. The top of the page is used as a sort of general messaging area, so things like new versions, configuration errors, etc. would go there as well. It might make sense to duplicate that particular message and have one big red box at the top and a smaller message in the results area or something like that.

I don't think any options are missing, but feel free to clone my repo and have a look to let me know if I broke anything. I was only able to thoroughly test the things I actually use, so any additional testing would be much appreciated. Similarly for the other issues you mentioned, it would be awesome if you tried out the changes I made and let me know what you think. I'll push some more updates tomorrow with some of the changes you suggested.

Anyway, thanks for the feedback.

[pillone]

Very cool!

I have to analyze this well. Quite some of changes have happened in the upcoming version (0.45_RC1 branch). I see what I can merge.

Definitively a really interesting work.

[PeterBeard]

I was dumb and didn't notice the new branches, so I've merged the changes in 0.45RC1 into my repo. I'm closing this pull request and I'll open another one for the 0.45 branch.

Edit: new pull request is pillone/usntssearch#67