pillone / usntssearch

NZB Metasearch engine
pillone.github.io/usntssearch
263 stars 79 forks source link

Reverse proxy support for configuration saving #91

Closed DamnDam closed 10 years ago

DamnDam commented 10 years ago

This issue completes #65

Reverse proxy works great in 0.45, but the configuration cannot be saved when accessing through the proxy. On the configuration page, the 'saveconfig' post call should be prefixed with the reverse proxy directory.

DamnDam commented 10 years ago

For example, on my installation, I solved this by hardcoding the reverse proxy prefix here :

templates/config.html#L389

$.post($SCRIPT_ROOT + "/revproxy/saveconfig", $("#cfgform").serialize(),
pillone commented 10 years ago

thanks for the report.

fixed in the 0.46RC_bugfix branch

DamnDam commented 10 years ago

Thank you =)

DamnDam commented 10 years ago

Hmm.. This is not fully OK.

In case you set up a wrong revproxy, you are definitely prevented from saving the configuration ever.

Bug replication :

IMHO, revproxy setting should be banned from the config page and be loaded from a configuration file on startup only.

pillone commented 10 years ago

thanks,

it is not easy to bring this functionality decently without having a rev proxy setup. It is basically based on user patches..

I fix this

DamnDam commented 10 years ago

Perfect ! Thank you for your work.