pillone / usntssearch

NZB Metasearch engine
pillone.github.io/usntssearch
263 stars 79 forks source link

Allow user to set a fully qualified URL to NZBMegasearcH for SABnzbd #93

Closed DamnDam closed 10 years ago

DamnDam commented 10 years ago

This one needs some explaining.

I believe we need to upgrade the setting 'general_ipaddress'.

On my case SABnzbd needs to access the warp link on localhost. That's the purpose of the 'general_ipaddress' setting.

But the warp call doesn't seems to handle revproxy correctly, so when SABnzbd tries to access something likehttp://localhost:5000/revproxy/warp?x=xxxxx this doesn't work.

What I propose, is to allow users to set a full URL to NZBMegasearcH from SABnzbd point of view. In my case I could set something like sab_revlink=http://localhost:5000, and SABnzbd would get http://localhost:5000/warp?x=xxxxx

For others this could be sab_revlink=http://fancy-host/reproxy SABnzbd would get http://fancy-host/reproxy/warp?x=xxxxx

DamnDam commented 10 years ago

To make everything work correctly on my installation, I set general_ipaddress=localhost and edited megasearch.py#L393

name=send2sab_exist+'/'+args['data'],

(removed the revproxy)

pillone commented 10 years ago

Hi,

why does http://localhost:5000/revproxy/warp.. is not working? If your reverse proxy is making http://localhost:5000/revproxy -> http://localhost:5000 it should work correctly

I think I have to do a similar setup so that I fix this permanently.

DamnDam commented 10 years ago

Thanks for your answer.

My reverse proxy does not use port 5000 that's the beauty of it. I use reverse proxy to display all my web services on port 80. That's the reason why a lot of reverse proxy users do that in the first place.

So my reverse proxy does http://localhost/revproxy -> http://localhost:5000, the port number changes... There is no way for the application to predict it. That's why I'd recommend using full URL for sabnzbd warp calls.

pillone commented 10 years ago

AH!

I see, I didn't get well the idea. yes you are right.

Stay tuned on the 046_RC branch :)

pillone commented 10 years ago

Hey there,

it should be done ok now. 046_RC branch.

Let me know.

DamnDam commented 10 years ago

Sorry for the delay !

It works perfectly on my end. I have been able to remove all my temporary fixes when switching to 0.46bugfix.

Thanks a lot :)