pillowlab / neuroGLM

Fitting and analysis of trial-based neural spike responses with Generalized Linear Model (GLM).
MIT License
67 stars 38 forks source link

Missing files ? "buildGLM.buildModel" "fitGLM" and more ? #16

Open adehad opened 3 years ago

adehad commented 3 years ago

Have unsuccessfully tried to run tutorial.m, seemingly because it is unclear what fitGLM and buildGLM.buildModel resolve to.

Initial Point of Failure

https://github.com/pillowlab/neuroGLM/blob/e6034915a1cd77d59c81ed29340c13982bfd505f/tutorial.m#L120-L130

Line 130 references an unresolved model variable that seems to be set in the previously commented L121-L126.

Uncommenting the commented lines is also funky:

  1. buildGLM.buildModel does not exist
  2. fitGLM I assume should exist under buildGLM but it does not. Currently it conflicts with Matlab's inbuilt fitglm

Giving a quick look through the available source in this repo neuroGLM\matRegress\+glms\autoFitGLM.m is the closest to actually returning a model, but does not seem to match the function call in L130?

https://github.com/pillowlab/neuroGLM/blob/e6034915a1cd77d59c81ed29340c13982bfd505f/matRegress/+glms/autoFitGLM.m#L1

Likely Further Points of Failures

https://github.com/pillowlab/neuroGLM/blob/e6034915a1cd77d59c81ed29340c13982bfd505f/tutorial.m#L136-L141

Afterwards I imagine generatePrediction, simulateModel, goodnessOfFit, visualizeGoodnessOfFit would also be unresolved as I cannot find anything with those names in the repo.


Am I missing something obvious? The docs/tutorial.md does seem to suggest another approach using the dm matrix that I can explore further, but I was expecting the tutorial to work in the first instance regardless.

https://github.com/pillowlab/neuroGLM/blob/e6034915a1cd77d59c81ed29340c13982bfd505f/docs/tutorial.md#L185-L186

haileygordon commented 2 years ago

Also curious about this inquiry above.