search

pilot51 / voicenotify

Android app that speaks notifications
https://voicenotify.app
Apache License 2.0
165 stars 57 forks source link

redesign application ui #132

Open icai opened 5 months ago

icai commented 5 months ago

redesign application ui

pilot51 commented 5 months ago

It may be a good idea to create a separate PR for just the translation. That should be quick to push through. The redesign is holding it back.

pilot51 commented 3 months ago

I find that the Ignore None switch is confusing. It would be less confusing to call it "Enable All", but I think it would be more intuitive to keep ignore all/none as separate actions, as it was originally, so it can double as a "reset all to default". If we use a switch, I think it should reflect appDefaultEnable. One thing that was missing from the original design was an indication of what the default is.

Suggestions:

  1. Go back to the old way, with Ignore All and Ignore None options.
  2. Change the switch to "Enable by Default" and have it only toggle appDefaultEnable without toggling any apps. Add the separate Ignore All and Ignore None options. Changing the default won't need the confirmation, but the bulk actions will.
  3. Change the switch to "Enable by Default" and show a confirmation dialog that provides options to reset all apps to the new default, only change the default, or cancel.

On another note, I was waiting for all my concerns with this PR to be resolved so I could include it in v1.4.0. Unfortunately that's holding things up more than I had anticipated, so for now I'll plan on getting this in v1.5.0. That includes the translation unless you split that into another PR or add it through Weblate.

icai commented 2 months ago

@pilot51 AI translation should be faster. Copy the default Value string.xml file, prompt:{content} translate all value to chinese, keep the order, return all of the content. And the Suggestions I will review again. image.

pilot51 commented 1 month ago

I tried using AI translations once and someone who knew the language that I translated to told me to never do that again. Often the translations don't come out right because it doesn't understand the context. Since I am personally unable to verify a translation because I am not familiar with the language, I will not be using AI translation. I don't care if contributing translators use AI, but I have to trust that they understand the language and proofread it.