pilot51 / voicenotify

Android app that speaks notifications
https://voicenotify.app
Apache License 2.0
152 stars 54 forks source link

Many fixes! #18

Closed ScottAlbertine closed 10 years ago

ScottAlbertine commented 10 years ago

Fix the null pointer exception where mTts is null Fix the threading so that speak() is always called in a thread Update the deprecated onUtteranceCompletedListener to an UtteranceProgressListener Add onCreate method to save the compute time of recreating the mTts object on every batch of messages Add a thread-safe queue to properly ensure shake/audio focus handling with multiple asynchronous calls to speak()

pilot51 commented 10 years ago

Thanks! I'll test it over the week and should have it merged by this weekend. Following the code review process (as I understand it), I suggest you make changes requested by my comments in your branch and update the pull request.