pilot51 / voicenotify

Android app that speaks notifications
https://voicenotify.app
Apache License 2.0
150 stars 54 forks source link

Rereading entire updated notifications #61

Closed haxwithaxe closed 6 years ago

haxwithaxe commented 6 years ago

v1.1.2 is rereading the whole notification when that notification is updated. I've only noticed this with telegram but that is the only app that gets stacked up like that for me. Let me know if there is anything I can do to help.

Expected

  1. Existing notification hello, world

  2. Reads: "hello, world"

  3. Notification is updated to append "how are you". Displays:

    hello, world
    how are you
  4. Reads: "how are you"

Observed

  1. Reads "hello, world how are you"
pilot51 commented 6 years ago

Is the updated notification the same one or a new one in Telegram's notification group (appearing as a single notification when the group is collapsed)? If the former, a fix to determine what has already been spoken in an updated notification may be a bit more complicated. I am aware of the latter happening in some cases, such as with Gmail, where it repeats notifications from a group when a new notification is added to the group, which I still need to get around to fixing.

haxwithaxe commented 6 years ago

I think it's as a group.