search

pilot51 / voicenotify

Android app that speaks notifications
https://voicenotify.app
Apache License 2.0
150 stars 54 forks source link

Upload New Icon Vectors #67

Closed cedenoruel closed 6 years ago

cedenoruel commented 6 years ago

I uploaded the vectors and some exports for the new icon and logo. Feel free to delete the unnecessary exports. I also noticed there's no README file yet so I created one.

pilot51 commented 6 years ago

Pull request is not really ideal for external development resources because it bloats the repository, in this case more than doubling its compressed size, which is effectively permanent (as long as they're in the history, and it's bad practice to delete history once it publicly hits master). I'll probably only use about 7 of the icon bitmaps in the app. Everything else, including vectors and what I use in the Play Store, I try to keep out of git. Best would have been to put them in a zip (or archive format of choice) and attach to #65.

That said, I have pulled it to my local machine to get the images, but I won't be merging it. Sorry.

Nevertheless, thank you for your work!

cedenoruel commented 6 years ago

Apologies. I'm still new to github so I didn't know that. Thanks for letting me know. If you need more graphic requests, feel free to contact me. Looking forward to seeing the new icon in the app. Cheers!