Possible wrong parameter reference

pilotak / homeassistant-attributes

Breaks out specified attribute from other entities to a sensor

Apache License 2.0

101 stars 11 forks source link

Possible wrong parameter reference #30

Closed mrfind closed 3 years ago

mrfind commented 3 years ago

Just from reading and trying to understand the code: Shouldn't line 57 compare the state to {3} rather than {2}? Comparing it to time_format doesn't seem right. This may have happended because parameters in line 82 have a different order.

I'd try to fix it myself but I'm still new to Home Assistant programming and GitHub and I have yet to try my first pull request...

Anyway, thanks a lot for providing this component! Martin

pilotak commented 3 years ago

Thanks fo finding a bug. You are right. Anyway try to submit a PR I will review it, you can't do anything wrong.

mrfind commented 3 years ago

Ok, I'll look into it over the weekend. I should really learn this anyway!

pilotak commented 3 years ago

fixed via #31