search

pilotmoon / PopClip-Extensions

Source code for extensions in the official PopClip Extensions directory.
https://www.popclip.app/extensions/
MIT License
1.92k stars 442 forks source link

Add Hypothesis extension #1177

Closed cdpath closed 2 years ago

cdpath commented 2 years ago

PopClip extension for Hypothesis.

Highly influenced by readwise extension.

danieltomasz commented 2 years ago

@cdpath I tried to install this extension but it doesnt seem to login after pasting hypothesis key

cdpath commented 2 years ago

@cdpath I tried to install this extension but it doesnt seem to login after pasting hypothesis key

Can you try this 'compiled' version? https://github.com/cdpath/hypothesis_it/releases/tag/v0.0.2

BTW, remember to set user_id and group_id as well, which can be found in https://hypothes.is

pilotmoon commented 2 years ago

Thanks for this. Nice job!

The reason it was failing for @danieltomasz is that the extension needs the network entitlement, which was missing from the config file. I've added that in 0492a20.

Being not a Hypothesis user I haven't been able to test it properly yet. There are some improvements that I would make before I would publish this to the main directory, including using the OAuth properly to sign in. But, still looks useful as it is so have fun!

ps. I'll be moving all user-contributed extensions to a different source directory in the near future so be forewarned it may move.

danieltomasz commented 2 years ago

@invariant After trying to install the newly added Hypothesis.popclipextz I am getting the following error

Cannot Install Extension
Failed to unzip extension.
Extension: Hypothesis.popclipextz
pilotmoon commented 2 years ago

@danieltomasz Can you try again, I have rebuilt it since then. https://github.com/pilotmoon/PopClip-Extensions/raw/master/extensions/Hypothesis.popclipextz

danieltomasz commented 2 years ago

it's ok now! thanks!