search

pilwon / node-yahoo-finance

Yahoo Finance historical quotes and snapshot data downloader written in Node.js
495 stars 123 forks source link

Allow volume and market cap fields #1

Closed dylants closed 10 years ago

dylants commented 10 years ago

"The CSV column mis-alignment doesn't seem to occur with the volume, market capitalization, and market cap (realtime) fields. Allow these fields to be queried."

I've tested these changes with multiple stocks, and don't come across any problems (as I would with other fields that do have this problem). I find these fields to be important, and really like the simplicity of your module. Would it be possible to accept this pull request and enable these fields to be queried?

Thanks!

pilwon commented 10 years ago

@dylants Have you tried shuffling the field order? At the time I worked on this library I think the order screwed it up.

dylants commented 10 years ago

@pilwon I tried not specifying any fields, which will then default them to all, specifying a set of fields that include "v", "j1", and "j3", and rearranging them as you've suggested, and there have been no problems with the 10 or so stocks that I've tried. I believe the problem would occur when a field has a comma in it, correct? These fields don't appear to have commas in them, perhaps they did at an earlier time. For instance, AAPL returns:

"volume": "8471356", "marketCapitalization": "468.0B", "marketCapRealtime": "N/A"

For "v", "j1", and "j3". Granted I haven't gotten the marketCapRealtime to show anything but "N/A", but as you can see the other fields do not have commas, which shouldn't mess with the CSV parsing.

pilwon commented 10 years ago

@dylants Thanks for your detailed analysis. I trust that you have thoroughly tested this and since you seem to be using this module more than I do at the moment, I'll merge and watch for any new bug from this merge afterwards. Please report and submit PR to improve this module.

pilwon commented 10 years ago

Published to NPM as v0.1.1

dylants commented 10 years ago

@pilwon Thanks! Very much appreciate the work you've done and the quick response to the PR :)