Closed brianedgerton closed 9 years ago
@brianedgerton Thanks this is great. Would you be able to change the double quotations used for string to single quotations for code consistency?
@pilwon Sorry about that. We use double quotes at work :)
Submitted a pull request to correct the fact that, while this fixed historical dates, it broke snapshot dates.
I'm using this for a pet project and I noticed that the lib was not creating dates correctly from the string in the historical data CSV. The
Date
object being created was actually a day earlier than the specified string. Not sure exactly why this was happening, but, sincemoment
was already available, I fixed it by creating themoment
object with an explicit format and then grabbing the raw JS date object. Seems to work.Thanks for the library!