search

pilwon / node-yahoo-finance

Yahoo Finance historical quotes and snapshot data downloader written in Node.js
491 stars 123 forks source link

Why are some fields removed? #25

Open tjunghans opened 8 years ago

tjunghans commented 8 years ago

I really like this package as it's easy to use and serves my requirements. I did spend some time figuring out why a5 and b6 are never returned and found out that these fields, including others, are removed.

The reason given is to avoid csv column result mis-alignment. I don't fully understand the issue, probably because I'm not that familiar with the quality of the data returned by Yahoo. I would bet that there's a better solution to handling this, than to remove the fields.

I'm willing to help with this and create a pull request. It would appreciate a bit more information as to why these columns are removed i.e. how or when the mis-alignment occurs. Cheers.

pilwon commented 8 years ago

@tjunghans I believe those fields when combined with other fields caused some parsing issues with commas, but the best way is to play with those fields and investigate what's really going on there. Looking forward to your PR. Thanks for your help!