pilwon / node-yahoo-finance

Yahoo Finance historical quotes and snapshot data downloader written in Node.js
491 stars 123 forks source link

Yahoo Finance v7 API (since 2017-05-16) - finish snapshot (2/3) #41

Closed gadicc closed 7 years ago

gadicc commented 7 years ago

Continuation from #37 for snapshot().

gadicc commented 7 years ago

@pilwon, ok, changed my mind :) This PR is just for snapshot(). Sorry, I just saw all your references to this issue but your earlier comments about shipping as early as possible have been stuck in my mind and I think this is ready to ship and might help some people.

Take a look through the changes and please try any of your own tests if you have any. You can ignore my merge messages in the commits and just squash everything. Everything else really should be in one final PR, which is less time sensitive. I'll update all the other threads with links when I open it.

gadicc commented 7 years ago

oh actually just wait one sec, sorry.

gadicc commented 7 years ago

Ok I just rebased on my end down to 5 sensible commits, which I think you can merge now without squashing. It's a lot clearer to have i.e. file splits and unrelated changes in their own commits.

pilwon commented 7 years ago

@gadicc Awesome! 👍 👍 👍