search

pimalaya / himalaya

CLI to manage emails
https://pimalaya.org
MIT License
3.17k stars 95 forks source link

Editor opening subprocess now works properly with in-terminal editors. #457

Closed d2718 closed 1 year ago

d2718 commented 1 year ago

However the process-lib crate's Cmd runs subprocesses doesn't play nice with in-terminal editors like nano or Helix. I replaced this with an explicit use of tokio::process::Command; the result seems to work properly with both in-terminal and graphical editors.

d2718 commented 1 year ago

Okay, this is embarrassing; I can't get this to work anymore. Please stand by.

michael2to3 commented 1 year ago

Hi. You can check my pr it solves the same problem but in a different way

soywod commented 1 year ago

Thank you for the fix, I appreciate the initiative! We should fix process-lib instead of Himalaya CLI, see my comment https://github.com/soywod/himalaya/pull/456#issuecomment-1791960641. A fix will come very soon.