search

pimatic / pimatic-homeduino

Pimatic plugin for using 433mhz devices and sensors with a connected Arduino with homeduino sketch
https://pimatic.org/
GNU General Public License v2.0
37 stars 29 forks source link

Included new command (DST) for Dallas temperature sensors DS18B20 #29

Closed ronaldsteen closed 9 years ago

ronaldsteen commented 9 years ago

Hi,

I've included a new command that let's you read a Dalles DS18B20 temp sensor on digital pin 2. I've also added this command to homeduino and homeduinojs so it's usable in Pimatic.

Let me know what you think. Would be great if it could be included in the official packages.

Cheers, Ronald

sweetpi commented 9 years ago

Nice, I will correct the DST device. I think there are no checksum errors and stuff, right?

sweetpi commented 9 years ago

I've done some cleanup, could you test if its working? Then I will release a new version.

ronaldsteen commented 9 years ago

Nice. I'll try testing all the modules on monday or tuesday evening.

ronaldsteen commented 9 years ago

I see you've removed the lines below from homeduino.coffee . Are those attribures already inherited from TemperatureSensor? If not, I guess they're kinda required.

    attributes:
      temperature:
        description: "the messured temperature"
        type: "number"
        unit: '°C'
sweetpi commented 9 years ago

I see you've removed the lines below from homeduino.coffee . Are those attribures already inherited from TemperatureSensor? If not, I guess they're kinda required.

Yes those are.

ronaldsteen commented 9 years ago

Still had some time to test it tonight. All is working fine.