pimatic / pimatic-homeduino

Pimatic plugin for using 433mhz devices and sensors with a connected Arduino with homeduino sketch
https://pimatic.org/
GNU General Public License v2.0
37 stars 29 forks source link

Updated configurability #32

Closed ronaldsteen closed 9 years ago

ronaldsteen commented 9 years ago

Hi,

I've updated configurability. You can now specify pins and addresses.

Cheers, Ronald

ghost commented 9 years ago

I`m just testing your versions of homeduino and pimatic-homeduino. It seems to miss an action called readDstSensors, which is called at the beginning of homeduino.coffee.

error [pimatic-homeduino]: Couldn't connect to homeduino device: Object # has no method 'readDstSensors'.

ronaldsteen commented 9 years ago

It requires the adjusted version of homeduinojs too. By default you get the current version of that package. You can replace it by manually cloning my homeduinojs version in your node_modules folder.

Let me know if you need more detailed instructions for testing it.

ghost commented 9 years ago

Sorry, seems that it did not copy homeduninojs. Now it is working. Although there seems to be a wrong type of the temperature variable.

in homeduino.coffee: attributes: temperature: description: "the meassured temperature"
type: "string"
unit: '°C' pin: "number" address: "string"

I think it should be: attributes: temperature: description: "the meassured temperature"
type: "number" <---- has to be number
unit: '°C' pin: "number" address: "string"

ronaldsteen commented 9 years ago

Thanks. I've just updated it.

sweetpi commented 9 years ago

I've remote the pin and address attribute, because I think it does not make much sense to have this as an attribute visible in the gui.

Thanks again for the additions. Please sync back my changes to your repository if you want to make additional changes.

ronaldsteen commented 9 years ago

Ok, I think you're right. On za 28 feb. 2015 at 19:51 sweet pi - sweet home notifications@github.com wrote:

I've remote the pin and address attribute, because I think it does not make much sense to have this as an attribute visible in the gui.

Thanks again for the additions.

— Reply to this email directly or view it on GitHub https://github.com/pimatic/pimatic-homeduino/pull/32#issuecomment-76539738 .

ghost commented 9 years ago

Could it be that you deleted the temperature attribute with the pin and the address attribute? Or am I blind :(

ronaldsteen commented 9 years ago

I thought the format was wrong.. pin and address were part of temperature, now they're separate attributes.

attributes:
      temperature:
        description: "the meassured temperature"    
        type: "number"    
        unit: '°C'
      pin:
        description: "The pin that the sensor is connected to."
        type: "number"
      address:
        description: "The address of the sensor."
        type: "string"
sweetpi commented 9 years ago

Could it be that you deleted the temperature attribute with the pin and the address attribute? Or am I blind :(

I delete all, because the temperature attribute gets inherit from TemperatureSensor anyway.

ghost commented 9 years ago

thanks for your explanation. I`m just getting the hang of the programming for ardunio and pimatic (coffee)