search

pimatic / pimatic-homeduino

Pimatic plugin for using 433mhz devices and sensors with a connected Arduino with homeduino sketch
https://pimatic.org/
GNU General Public License v2.0
37 stars 29 forks source link

Extension of HomeduinoRFShutter with xOnLabel and xOffLabel doesn't work #70

Closed michbeck100 closed 6 years ago

michbeck100 commented 7 years ago

device-config-schema.coffee states that a HomeduinoRFShutter can be extended with different labels for the two buttons it comes with. This doesn't work. When used pimatic fails to create the device because it doesn't have a state attribute and then it crashes here. Since a state attribute doesn't make sense for shutters, i would say we need an extension for shutters like "xUpLabel" and "xDownLabel". But this would include changes in pimatic and pimatic-mobile-frontend.

mwittig commented 7 years ago

I am getting a "Cannot read property 'labels' of undefined" error when I am trying save the device. I think the use use of xOn and xOff is simply wrong in this context and thus needs to be removed from the device template. I'll do that asap.

See also https://github.com/pimatic/pimatic/issues/294

It should be possible to implement something appropriate for shutter possition, but I consider this as a feature request to be file on pimatic forum

mwittig commented 6 years ago

To be released

qistoph commented 5 years ago

A bit late to the conversation, but just now running into this issue myself.

Why were these labels removed? I'm using the KaKu ASUN-650 for my drapes and would really like to change the options 'Up'/'Down' to 'Closed'/'Open'. Those would be more applicable to drapes closing from left and right.

mwittig commented 5 years ago

Please have a look at the first and second post for background. So far no feature request for "xUpLabel" and "xDownLabel" has been raised. For this reason I did not put ti on my todo list

https://forum.pimatic.org/category/14/feature-requests

mwittig commented 5 years ago

I have implemented the stuff assuming there would be two upvotes at least :)