search

pimatic / pimatic-homeduino

Pimatic plugin for using 433mhz devices and sensors with a connected Arduino with homeduino sketch
https://pimatic.org/
GNU General Public License v2.0
37 stars 29 forks source link

Added config option to invert signal that is send for shutters #71

Closed michbeck100 closed 7 years ago

michbeck100 commented 7 years ago

Some people train their RF receiver of their shutter using the wrong button on a remote. Then the receiver is put into the wall and it's not easy to train it again. After adding the shutter device to pimatic, the button press for Up sends the shutter down and vice versa. This change adds a new option "inverted" which solves this problem, by just sending the opposite signal than normal if "inverted" is true.

michbeck100 commented 7 years ago

Any comments on this PR?

michbeck100 commented 7 years ago

@mwittig Any chance this PR gets merged?

michbeck100 commented 7 years ago

@sweetpi @mwittig it would be great if you could review my changes. THX

mwittig commented 7 years ago

Honestly, I don’t see the need for this PR, but I have no experience with shutters. So, I leave this to @sweetpi to decide.

sweetpi commented 7 years ago

I'm ok with this change.

mwittig commented 7 years ago

OK, fine