search

pimatic / pimatic-homeduino

Pimatic plugin for using 433mhz devices and sensors with a connected Arduino with homeduino sketch
https://pimatic.org/
GNU General Public License v2.0
37 stars 29 forks source link

add rollingTime to support moving by percentage #87

Closed michbeck100 closed 6 years ago

michbeck100 commented 6 years ago

This change is analogous to the changes made in https://github.com/pimatic/pimatic/pull/920 for the DummyShutter

0rTiN commented 6 years ago

Please bring this in the next version.

mwittig commented 6 years ago

Sure. Will do among other things required for homeduino like the migration to new Serialport implementation and the integration of the new virtual homeduino build

2017-12-20 19:35 GMT+01:00 0rTiN notifications@github.com:

Please bring this in the next version.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pimatic/pimatic-homeduino/pull/87#issuecomment-353146089, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1ZbtijjBOuMSHiqZToTf7MrHMJBYpMks5tCVNigaJpZM4QhpWM .

0rTiN commented 6 years ago

Wonderfull. Will this come soon or does it need longer time to release the new functions?

mwittig commented 6 years ago

Well someone needs to test the feature

0rTiN commented 6 years ago

I can do it.

0rTiN commented 6 years ago

I tried to replace the relevant files, but pimatic was not starting anymore. How can I make it running for a test?

michbeck100 commented 6 years ago

Like this: https://stackoverflow.com/questions/6022302/how-to-apply-unmerged-upstream-pull-requests-from-other-forks-into-my-fork and then install the plugin from github

michbeck100 commented 6 years ago

Will this be in the next release, too?

theslash commented 3 years ago

Is this already implemented? Can I do something to help?

michbeck100 commented 3 years ago

@theslash you could test if the rolling time works for you.

theslash commented 3 years ago

Ok, so I set a rolling time for one of my shutters of 23 seconds. When I then call the moveByPercentage like this: curl -X GET "http://192.168.1.5:8080/api/device/rollo-esszimmer/moveByPercentage?percentage=-10" the shutter moves down approx 10% and so on, when I use positive numbers, then it moves up. So this is good I think.