search

pimatic / pimatic-sysinfo

Plugin for displaying system and process information such as CPU and Memory usage for pimatic
https://pimatic.org/
GNU General Public License v2.0
2 stars 4 forks source link

add systemUptimeDHM and pimaticUptimeDHM #20

Closed hvdwolf closed 5 years ago

hvdwolf commented 5 years ago

I created a pull request that adds "systemUptimeDHM" and "pimaticUptimeDHM" that displays these uptimes as "days hours minutes". When less then an hour it only displays 59 minutes When less than a day it displays 23 hours, 59 minutes When more than a day it displays 999 days, 23 hours, 59 minutes

in the config.json

    {
      "name": "systemUptimeDHM",
      "interval": 120000
    },
    {
      "name": "pimaticUptimeDHM",
      "interval": 120000
    }
mwittig commented 5 years ago

@hvdwolf What is your opinion on this? Is it OK to drop this PR thanks to the displayFormat feature or should be keep this?

hvdwolf commented 5 years ago

It can be dropped. The same functionality is already available thanks to your extension of the displayformat