search

pimatic / rfcontroljs

nodejs modul with protocol support for different 433mhz switches and weather stations for the RFControl Arduino library.
GNU General Public License v3.0
49 stars 54 forks source link

Fault in 0.0.59 release #126

Closed qistoph closed 5 years ago

qistoph commented 5 years ago

The 0.0.59 release on npmjs.org contains an error in `lib/protocols/switch13.js' that is causing an issue starting pimatic (https://github.com/pimatic/pimatic-homeduino/issues/91).

$ mkdir rfcontroljs-0.0.58
$ mkdir rfcontroljs-0.0.59
$ wget https://registry.npmjs.org/rfcontroljs/-/rfcontroljs-0.0.58.tgz
$ wget https://registry.npmjs.org/rfcontroljs/-/rfcontroljs-0.0.59.tgz
$ tar x -C rfcontroljs-0.0.58/ -f rfcontroljs-0.0.58.tgz
$ tar x -C rfcontroljs-0.0.59/ -f rfcontroljs-0.0.59.tgz

$ hexdump -C rfcontroljs-0.0.58/package/lib/protocols/switch13.js | head
00000000  6d 6f 64 75 6c 65 2e 65  78 70 6f 72 74 73 20 3d  |module.exports =|
00000010  20 66 75 6e 63 74 69 6f  6e 28 68 65 6c 70 65 72  | function(helper|
00000020  29 20 7b 0a 20 20 76 61  72 20 62 69 6e 61 72 79  |) {.  var binary|
00000030  54 6f 50 75 6c 73 65 2c  20 70 72 6f 74 6f 63 6f  |ToPulse, protoco|
00000040  6c 49 6e 66 6f 2c 20 70  75 6c 73 65 73 54 6f 42  |lInfo, pulsesToB|
00000050  69 6e 61 72 79 4d 61 70  70 69 6e 67 3b 0a 20 20  |inaryMapping;.  |
00000060  70 75 6c 73 65 73 54 6f  42 69 6e 61 72 79 4d 61  |pulsesToBinaryMa|
00000070  70 70 69 6e 67 20 3d 20  7b 0a 20 20 20 20 27 31  |pping = {.    '1|
00000080  30 27 3a 20 27 31 27 2c  0a 20 20 20 20 27 30 31  |0': '1',.    '01|
00000090  27 3a 20 27 30 27 2c 0a  20 20 20 20 27 32 27 3a  |': '0',.    '2':|

$ hexdump -Cv rfcontroljs-0.0.59/package/lib/protocols/switch13.js | head
00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000020  00 00 00 00 00 00 00 00  72 20 62 69 6e 61 72 79  |........r binary|
00000030  54 6f 50 75 6c 73 65 2c  20 70 72 6f 74 6f 63 6f  |ToPulse, protoco|
00000040  6c 49 6e 66 6f 2c 20 70  75 6c 73 65 73 54 6f 42  |lInfo, pulsesToB|
00000050  69 6e 61 72 79 4d 61 70  70 69 6e 67 3b 0a 20 20  |inaryMapping;.  |
00000060  70 75 6c 73 65 73 54 6f  42 69 6e 61 72 79 4d 61  |pulsesToBinaryMa|
00000070  70 70 69 6e 67 20 3d 20  7b 0a 20 20 20 20 27 31  |pping = {.    '1|
00000080  30 27 3a 20 27 31 27 2c  0a 20 20 20 20 27 30 31  |0': '1',.    '01|
00000090  27 3a 20 27 30 27 2c 0a  20 20 20 20 27 32 27 3a  |': '0',.    '2':|

There are 40 0-bytes in switch13.js file. These are not in the repo. Recreating and uploading the release might fix it.

mwittig commented 5 years ago

Thanks, for the perfect investigation. I am not sure how these nul-bytes came in. Looks like a corrupted disk caused the issue. The new release looks greener