search

pimatic / rfcontroljs

nodejs modul with protocol support for different 433mhz switches and weather stations for the RFControl Arduino library.
GNU General Public License v3.0
49 stars 54 forks source link

Update Weather4 #20

Closed Icesory closed 9 years ago

Icesory commented 9 years ago

@sweetpi i think we should change the id and channel for the weather devices to optional.

sweetpi commented 9 years ago

Wow, very nice. Thanks again for the good work. It would by nice if you could try to write more meaningful commit messages.

What do you mean by changing the ID and channel to optional? Its already optional in pimatic-homeduino.

Icesory commented 9 years ago

I looked at the doesProtocolMatch function after this pull request. So nothing must to do. :)

I have one question. When I push a commit from my Linux I use git commit - m " xxx" To set the header of the commit. Is it possible to declare a second text block like in github.com?

For the next things I will try to wrote better commit messages.

Icesory commented 9 years ago

I see now i called the commit Weather4 but i have made some changes in weather1. sorry for this. What must i do to solve this?

sweetpi commented 9 years ago

No worries. I merge it this time :)