search

pimatic / rfcontroljs

nodejs modul with protocol support for different 433mhz switches and weather stations for the RFControl Arduino library.
GNU General Public License v3.0
49 stars 54 forks source link

Fixed elro home easy protocol #39

Closed Xento closed 9 years ago

Xento commented 9 years ago

It is better to use the second state and invert it, because I think it's more compatible. Pilight does it the same way. With this change I can use my wallswitches with this protocol.

sweetpi commented 9 years ago

Looks good, let's hope that it does not break anything.

8 commits for an single code line change looks like a overkill for me :).

Could you please do the following:

git checkout Fixed-Elro-Home-Easy-protocol # to be sure to be on the branch
# make a backup of the changed file(s)
git reset --hard 4c9f112e85e0dbe924991725bcef82c3cd4ee21b # reset to my last commit
# restore the changed file(s)
git commit -a -m "use reverted state in elro home easy protocol (switch2)"
git push -f
Xento commented 9 years ago

Yeah, I tried to delete the unnessesary changes ^^ Now it looks better.

sweetpi commented 9 years ago

Thanks.