pimatic / rfcontroljs

nodejs modul with protocol support for different 433mhz switches and weather stations for the RFControl Arduino library.
GNU General Public License v3.0
49 stars 54 forks source link

New protocol : doorbell1 for ADEO hardware #48

Closed Yves911 closed 9 years ago

Yves911 commented 9 years ago

Currently i am using a SWITCH, but a doorbell device could be better. Door Bell could:

For now switch is ok and still enough

Icesory commented 9 years ago

This generally a bad idea to map the protocol

    '0101': '1' #binary 1
    '1010': '1' #binary 1
    '0110': '0' #binary 0

break it down to this

    '10': '1' #binary 1
    '01': '0' #binary 0

and i my opinion you should use id and unit instead of systemcode and programmcode. Most of the protocols use this.

Icesory commented 9 years ago

And you have forgot to generate the .js files

Yves911 commented 9 years ago

Thanks @Icesory i don't want to change the binary things (because i don't want to break it) and don't know how to generate the .js file

Icesory commented 9 years ago

I have changed the binary part to an more generic. You must only change your id and unit.

Yves911 commented 9 years ago

@Icesory thanks i see that you did the changes. I tried to refresh my pimatic-homeduino (and rfcontroljs) today BUT i still can't see doorbell1.js in lib/protocols. What i am doing wrong?

Icesory commented 9 years ago

You can pull the git rep. At the moment It isn't in the official npm

Yves911 commented 9 years ago

Okay tested it today and all works fine: big THANKS !!